Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Shared] Types refactor #173819

Merged
merged 4 commits into from
Jan 16, 2024
Merged

[Logs Shared] Types refactor #173819

merged 4 commits into from
Jan 16, 2024

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Dec 21, 2023 •
edited
Loading

📓 Summary

Closes #173493

This work improves typing for the dynamic util for lazily exported components, catching a couple of typing issues.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani changed the title refactor(log-shared): ai assistant factory type [Logs Shared] AIAssistant types refactor Dec 21, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
logsShared 11 0 -11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +116.0B
securitySolution 11.3MB 11.4MB +6.4KB
securitySolutionServerless 355.0KB 361.2KB +6.3KB
total +12.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
logsShared 27 32 +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logsShared 222.1KB 222.1KB -6.0B
securitySolutionServerless 40.6KB 40.6KB -1.0B
total -7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tonyghiani
tonyghiani commented Jan 16, 2024
View reviewed changes
.../public/pages/logs/log_entry_categories/sections/top_categories/category_example_message.tsx
@@ -79,7 +81,7 @@ export const CategoryExampleMessage: React.FunctionComponent<{
onMouseLeave={setNotHovered}
>
<LogEntryColumn {...columnWidths[timestampColumnId]}>
<LogEntryTimestampColumn format={exampleTimestampFormat} time={timestamp} />
<LogEntryTimestampColumn format={exampleTimestampFormat} time={time} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: caught typing issue thanks to typed dynamic implementation.

@tonyghiani tonyghiani changed the title [Logs Shared] AIAssistant types refactor [Logs Shared] Types refactor Jan 16, 2024
@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team labels Jan 16, 2024
@tonyghiani tonyghiani marked this pull request as ready for review January 16, 2024 09:10
@tonyghiani tonyghiani requested a review from a team as a code owner January 16, 2024 09:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@yngrdyn
Copy link
Contributor

yngrdyn commented Jan 16, 2024 •
edited
Loading

did we need to export the interfaces for something specific? or is the plan to use them somewhere else?

@tonyghiani
Copy link
Contributor Author

did we need to export the interfaces for something specific? or is the plan to use them somewhere else?

I exported them to solve the issue described in here in the CI Checks.

yngrdyn
yngrdyn approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyghiani tonyghiani merged commit 692a8ca into elastic:main Jan 16, 2024
23 checks passed
@tonyghiani tonyghiani deleted the 173493-update-log-assistant-types branch January 16, 2024 14:22
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs Shared] Refactor type checking on LogAIAssistant component
6 participants
@tonyghiani @apmmachine @kibana-ci @elasticmachine @yngrdyn @kibanamachine